Skip to content

ci: pin GitHub Actions to commit SHAs (3)#1659

Closed
mirkosalvato1-ctrl wants to merge 1 commit into
microsoft:mainfrom
mirkosalvato1-ctrl:pinguard/pin-actions-94105
Closed

ci: pin GitHub Actions to commit SHAs (3)#1659
mirkosalvato1-ctrl wants to merge 1 commit into
microsoft:mainfrom
mirkosalvato1-ctrl:pinguard/pin-actions-94105

Conversation

@mirkosalvato1-ctrl

Copy link
Copy Markdown

Why

Mutable Action tags (@v4, @main) can be retagged, which is a supply-chain risk.
This PR pins third-party Actions to full commit SHAs while keeping the tag in a comment.
Official actions/* tags are left unchanged (common maintainer preference).

Pins

  • actions/github-script@v6 -> d7906e4ad0b1
  • actions/github-script@v6 -> d7906e4ad0b1
  • actions/github-script@v6 -> d7906e4ad0b1

Reference: GitHub docs on using third-party actions securely.

@wenytang-ms

Copy link
Copy Markdown
Contributor

Thanks for the PR and for caring about supply-chain security!
However, this change doesn't quite fit here:
• The only third-party action in our workflows ( lee-dohm/no-response ) is already pinned to a SHA, so there's nothing third-party left to pin.
• This PR actually pins  actions/github-script , which is an official  actions/*  action — the opposite of what the description states ("Official  actions/*  tags are left unchanged").
• It's also inconsistent:  actions/checkout ,  setup-java , and  setup-node  are left on tags.
Since it contradicts its own stated policy and adds little value, I'm going to close this. Appreciate the effort regardless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants